summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2014-06-18plugins/runcmd.c: Remove superfluous newlineHolger Weiss1-1/+1
The puts(3) function already appends a newline character to the string.
2014-06-13tests: freebsds snmpd does not use quotesSven Nierlein1-1/+1
when returning syscontact. So make them optional since we want to test check_snmp and not the snmpd. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13tests: check_proc tests fail if uid -2 does not map to nobodySven Nierlein1-0/+1
so make sure our tests only run if -2 maps to nobody Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13tests: fping checks require being root or setuid rootSven Nierlein1-6/+8
on the fping binary. Check this before running the test. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13require at least HTTP::Daemon 6.01Sven Nierlein1-1/+2
since the test uses send_header from HTTP::Daemon::ClientConn which has been introduced in HTTP::Daemon 6.01
2014-06-12tests: testCmd has own timeout which overwrites local oneSven Nierlein1-15/+9
so add configurable/optional timeout to testCmd. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12tests: parts of the check_procs test only work when uid -2 existsSven Nierlein1-12/+16
skip those tests if the uid does not exist Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12Fix compilation with GnuTLSHolger Weiss1-0/+2
GnuTLS doesn't provide a SSL_CTX_check_private_key() function. Closes #1254.
2014-04-27Make check_disk work on Windows.Gunnar Beutner1-1/+20
2014-04-27Make check_users work on Windows.Gunnar Beutner2-4/+42
2014-04-27Make check_ping work on Windows.Gunnar Beutner1-2/+5
2014-04-24check_snmp: Handle SNMPv3 noAuthNoPriv properlyAnton Lofgren2-6/+15
The SNMPv3 noAuthNoPriv security level, somewhat unintuitively, requires a security name to be passed along together with the request. Check_snmp previously did not do this, causing snmpget to throw an error: "External command error: No log handling enabled - turning on stderr logging snmpget: No securityName specified" This patch fixes the issue by always providing the security name when noAuthNoPriv is specified. See also: https:://bugs.op5.com/view.php?id=8385. Signed-off-by: Anton Lofgren <alofgren@op5.com>
2014-04-04Remove the suggestion to run check_apt with --verbose since it doesn't do ↵Sam Kottler1-1/+1
anything
2014-04-04check_nt: add UPTIME to perfdata [sf#3434647]Jan Wagner1-1/+1
2014-04-03Fix check_mysql.c client options from fileawiddersheim1-6/+0
If you don't specify a group or a file to read data from the plugin tries to read from several files that don't exist and no groups.
2014-03-13check_pgsql: Add missing newline to --help outputHolger Weiss1-1/+1
2014-03-09build - avoid deprecated INCLUDESDavide Madrisan1-5/+6
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-02-20check_swap: Fix the plugin name that appears in the commentDavide Madrisan1-1/+1
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-02-18check_procs test fails if there is no user with uid 501Sven Nierlein1-9/+17
thats because check_procs verifys there is a user for a given uid filter. So even we use sample data for this test, we still need a real user. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-02-17check_ssh: Reverting a387120Jan Wagner1-2/+0
This seems to result into more problems in the wild then before 'fixing' it Closes Debian #739254 Reopen Debian #734811
2014-02-07Merge pull request #1234 from skottler/plugin_makefile_whitespaceThomas Guyot-Sionnest1-3/+2
Remove unnecessary whitespace in Makefile.am
2014-02-07Remove unnecessary whitespace in Makefile.amSam Kottler1-3/+2
2014-01-31Add perfdata in check_proc output testsThomas Guyot-Sionnest1-15/+15
2014-01-31Fix snmpd testsThomas Guyot-Sionnest1-1/+1
2014-01-31Enable tests in tests/ subdirsThomas Guyot-Sionnest1-0/+0
2014-01-31Handle negative values properly with check_snmpStephane Lapie1-1/+1
check_snmp becomes capable of evaluating negative values properly, but it might be returning CRITICALs where it used to return OK and was ignored, if a negative value turns out to actually be a valid value. If negative values are valid, this can be worked around, by adding "~:" to the warning/critical threshold : 100 -> ~:100
2014-01-31Add tests for negative thresholds in check_snmpThomas Guyot-Sionnest2-8/+36
Next commit will work on fixing these!
2014-01-30check_dig: Declare variable at the topHolger Weiss1-1/+2
C89 doesn't allow variable declarations to be intermingled with code.
2014-01-30check_dig: stick with integer devisionJan Wagner1-1/+1
This change saves us from having to link check_dig against "libm"
2014-01-30check_dig: timeout_interval is a global variableJan Wagner1-2/+0
which is already set to 10 seconds
2014-01-30check_dig: patch to make dig honor -t optionJan Wagner1-2/+9
When a timeout value is specified with the -t option, dig will sometimes timeout before the timer is actually reached. The problem occurs because the check_dig plugin does not pass the specified timeout value to dig, leaving dig to timeout with it's default value which seems to be around 10-15seconds. To reproduce: time ./check_dig -H 127.0.0.2 -l www.google.com -t 30 It will not run for 30secs, which is the expected behaviour. The following will work, because the timeout is less than the default dig timeout, so the plugin cancels the dig command: time ./check_dig -H 127.0.0.2 -l www.google.com -t 2 This fix passes the timeout value to dig, and sets the number of retries which tends to vary from system to system by default. Closes #1168
2014-01-29Update check_swap usageThomas Guyot-Sionnest1-3/+4
2014-01-29check_swap: add supports for a configurable state when there is no swapThomas Guyot-Sionnest1-2/+13
Check_swap used to allow no swap when thresholds were only specified in percent. This is no longer the case and the state now must be specified explicitly. The default is to always return CRITICAL when the swap is absent regardless of thresholds.
2014-01-29Move negate' translate_state() to utils_base.h mp_translate_state()Thomas Guyot-Sionnest1-24/+5
Also use strcasecmp imported from gnulib for simplicity
2014-01-29TypoThomas Guyot-Sionnest1-1/+1
2014-01-29Fix check_swap returning OK on & thresholds and no swapThomas Guyot-Sionnest1-1/+1
Return 0% free instead of 100% free when total swap is 0
2014-01-28check_disk: precise the help outputJan Wagner1-1/+1
Clarifying in the help output that we need either a device or mount point listed by the mount(8) command. (Closes: #1118) (Closes: #1170)
2014-01-28Clarify check_mysql test promptsThomas Guyot-Sionnest1-15/+17
Also default to "-u test -ptest" which are default MySQL accounts only missing the prescribed privileges. The database is no longer specified as it is not used. If wanted is should be its own parameter/tests.
2014-01-27Merge pull request #1200 from awiddersheim/add_file_options_mysql_queryThomas Guyot-Sionnest1-3/+23
Add ability to read from options file to check_mysql_query.c
2014-01-27check_dig: fix wrong IPv6 arguments orderThomas Guyot-Sionnest1-2/+2
2014-01-27Rename MP_STATE_DIRECTORY to MP_STATE_PATHThomas Guyot-Sionnest1-2/+2
2014-01-25Rename ENV variable, keep backward compatibilityThomas Guyot-Sionnest1-2/+2
Rename NAGIOS_PLUGIN_STATE_DIRECTORY to MP_STATE_DIRECTORY
2014-01-24check_ping: Fixing "time of day goes back"Jan Wagner1-1/+5
by Geoff Oakham <goakham at oanda.com> Patch of check_ping that allows it to gracefully handle when ping outputs to stderr "Warning: time of day goes back (-XXXXus), taking countermeasures." Closes: #809 and #1195
2014-01-24Fixing bug in average calculation (Submitted by Lars)Jan Wagner2-2/+2
The more important change: A fix for a bug which caused the check_ntp_time and check_ntp_time check to always take the first response from ntp and not the avarage since "j" is not increased anywhere. "i" should be used there instead. Partly Closes #956 and Closes #1166 Closes: #1089
2014-01-24Making AVG_NUM configurable by compiler define (Submitted by Lars)Jan Wagner2-0/+4
A minor change which makes the AVG_NUM configurable by compiler define. Partly Closed #956 and Closes #1166
2014-01-23fix smart attribute comparisonTilmann Bubeck1-3/+3
Each S.M.A.R.T. attribute is compared against a threshold. If it is LESSTHAN that threshold an error is reported. This patch fixes the problem, that attribute values EQUAL to the threshold are reported as error, which is wrong. Only LESSTHAN the threshold is an error. For more information see: http://www.hdsentinel.com/smart/index.php My SSD has some attributes which value and threshold are "0". Without the patch this is reported as errornous. ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE ... 172 Unknown_Attribute 0x0032 000 000 000 Old_age Always - 0 174 Unknown_Attribute 0x0030 000 000 000 Old_age Offline - 13 177 Wear_Leveling_Count 0x0000 000 000 000 Old_age Offline - 0 ... See also: * http://sourceforge.net/p/nagiosplug/patches/365/ * https://bugzilla.redhat.com/913085
2014-01-23Fix misleading option textThomas Guyot-Sionnest1-1/+2
As soon as a device is specified without using -d, anything else on the command line is ignored.
2014-01-23Disable SMART test commands in check_ide_smartThomas Guyot-Sionnest1-35/+20
check_ide_smart could disable offline auto tests but could not re-enable them. For this reason all SMART command modes have been disabled The disabled commands are -0/--auto-off, -1/--auto-on and -i/--immediate
2014-01-23Remove accidental tabs inserted in macroThomas Guyot-Sionnest1-1/+1
2014-01-23Make check_ide_smart default to nagios outputThomas Guyot-Sionnest1-28/+33
check_ide_smart was originally a smard control utility later converted to a monitoring plugin. the -n option (Nagios check) should therefore be the default. This patch deprecates the -n and -q switches, and make the other switches return nagios-compatible output (they are most likely used in eventhandlers, but returning nagios-compatible output makes it clear and easy to handle the return status)