summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2014-07-10check_procs: Add delay after forking in testMikael Falkvidd1-1/+1
Forking raises a race condition, where the parent might run the test before the child has had time to fork. If that happens, an error similar to this is produced: Failed test 'Output correct' at ./t/check_procs.t line 32. 'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;' doesn't match '/^PROCS OK: 1 process?/' Sleeping a bit should avoid the problem. It might be enough to sleep less than a second, but perl's built-in sleep function only supports integer seconds. In our build environment, the build failed 3 of 4 times before this patch. After the patch it failed 0 of 7 times. Signed-off-by: Mikael Falkvidd <mfalkvidd@op5.com>
2014-07-07plugins/netutils.h: Adjust UNIX_PATH_MAX for BSDHolger Weiss1-2/+2
On at least FreeBSD, NetBSD, OpenBSD, DragonFly, and OS X, this is hard-coded at 104 bytes. Closes #1267.
2014-06-30Merge PR #1265 from waja/check_tcp_server_addrJan Wagner2-5/+10
2014-06-30check_jabber.t - fixed tests for new status output including hostnameabrist1-3/+3
2014-06-30Merge pull request #1190 from waja/github780Sven Nierlein1-4/+20
check_ssh: check protocol
2014-06-28Merge pull request #1262 from waja/fix_aixSven Nierlein2-4/+3
Include common.h before any system headers.
2014-06-28Merge pull request #1264 from waja/check_nt_unitsSven Nierlein1-2/+2
check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.
2014-06-28Merge pull request #1263 from waja/coverity_fixesSven Nierlein5-10/+24
Serveral coverity fixes from nagios-plugins
2014-06-28tests: added check_dns performance data testSven Nierlein1-1/+2
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-06-28check_dns.c Added a bit more logic to thresholdsabrist1-4/+13
Added two if elses to cover when only one threshold is set.
2014-06-28check_dns: add warning and critical thresholds to perfdataJean-Claude Computing1-1/+8
2014-06-28Cleaned up status output of check_tcp changesabrist1-1/+1
2014-06-28check_tcp: also display the server addr when host_specified is set. This ↵Davide Madrisan1-2/+7
will help the admins when multiple checks are configured Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-06-28check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.abrist1-2/+2
2014-06-28plugins/negate.c - Function should not return.Spenser Reinhardt1-2/+2
Coverity 66479 - validate_arguments has no need to return anything, as it dies on error, yet was set to return an int. Set to void to resolve warning.
2014-06-28plugins/negate.c - Reorder if statement, aiobSpenser Reinhardt1-2/+1
Coverity 66480 - Potential array index out of bounds, since result was not verified to be positive prior to using as an index for state[]. Simply reording the if statement should resolve the issue. - SR
2014-06-28plugins/check_http.c - leakage fixSpenser Reinhardt1-4/+6
Coverity 66514 - Possible leakage and overflow with addr in redirect functionality. Not confirmed as null terminated, and externally gathered. Restrict string comparisons and duplications by size. - SR
2014-06-28plugins/check_ntp.c - Verify struct from responseSpenser Reinhardt1-2/+11
Coverity 66524 - req.data is not neccessarily null terminated but still feed to printf statements. This both does that, and verifies the struct more so than before. - SR
2014-06-28plugins/check_real.c - recv string null terminateSpenser Reinhardt1-0/+1
Recv into buffer is not properly null terminated prior to strstr and possible other string functions expecting a null termination. Simply take bytes received and use as an index to append \0 after. We are creating buffer[] with size of MAX_INPUT_BUFFER and recv with MAX_INPUT_BUFFER-1 so this should never overflow.
2014-06-28plugins/check_apt.c - Print uninitialized eregSpenser Reinhardt1-0/+3
Coverity 66531 - ereg.buffer can be printed without being initialized if do_include and do_exclude are null and critical is an invalid regex. While minor this may leak memory and cause undefined behavior.
2014-06-28Include common.h before any system headers.Eric J. Mislivec2-4/+3
This should fix some problems building on AIX.
2014-06-24tests: always build and test on travisSven Nierlein4-7/+61
also make test is now working on travis-ci Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-06-23check_ide_smart: Fixing spelling bugJan Wagner1-1/+1
2014-06-23check_mrtg: Fixing spelling bugJan Wagner1-1/+1
2014-06-23check_ups/check_dbi: Fixing spelling bugJan Wagner2-6/+6
2014-06-22check_radius.c: Add newline to die() callsHolger Weiss1-14/+14
Our die() function doesn't append a newline character to the message.
2014-06-22check_radius: Support FreeRADIUS Client libraryHolger Weiss1-7/+14
Allow for using the FreeRADIUS Client library instead of radiusclient or radiusclient-ng. The latter two projects are dead. Closes #1231.
2014-06-18plugins/runcmd.c: Remove superfluous newlineHolger Weiss1-1/+1
The puts(3) function already appends a newline character to the string.
2014-06-13tests: freebsds snmpd does not use quotesSven Nierlein1-1/+1
when returning syscontact. So make them optional since we want to test check_snmp and not the snmpd. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13tests: check_proc tests fail if uid -2 does not map to nobodySven Nierlein1-0/+1
so make sure our tests only run if -2 maps to nobody Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13tests: fping checks require being root or setuid rootSven Nierlein1-6/+8
on the fping binary. Check this before running the test. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13require at least HTTP::Daemon 6.01Sven Nierlein1-1/+2
since the test uses send_header from HTTP::Daemon::ClientConn which has been introduced in HTTP::Daemon 6.01
2014-06-12tests: testCmd has own timeout which overwrites local oneSven Nierlein1-15/+9
so add configurable/optional timeout to testCmd. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12tests: parts of the check_procs test only work when uid -2 existsSven Nierlein1-12/+16
skip those tests if the uid does not exist Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12Fix compilation with GnuTLSHolger Weiss1-0/+2
GnuTLS doesn't provide a SSL_CTX_check_private_key() function. Closes #1254.
2014-05-17Patch against issue 1062gcoxmoz1-3/+1
2014-05-17Update netutils.cgcoxmoz1-4/+8
Return an encoded state rather than an explicit state if a connection failed.
2014-05-17Update check_tcp.cgcoxmoz1-1/+1
Return the state asked for, if connection failed.
2014-04-27Make check_disk work on Windows.Gunnar Beutner1-1/+20
2014-04-27Make check_users work on Windows.Gunnar Beutner2-4/+42
2014-04-27Make check_ping work on Windows.Gunnar Beutner1-2/+5
2014-04-24check_snmp: Handle SNMPv3 noAuthNoPriv properlyAnton Lofgren2-6/+15
The SNMPv3 noAuthNoPriv security level, somewhat unintuitively, requires a security name to be passed along together with the request. Check_snmp previously did not do this, causing snmpget to throw an error: "External command error: No log handling enabled - turning on stderr logging snmpget: No securityName specified" This patch fixes the issue by always providing the security name when noAuthNoPriv is specified. See also: https:://bugs.op5.com/view.php?id=8385. Signed-off-by: Anton Lofgren <alofgren@op5.com>
2014-04-04Remove the suggestion to run check_apt with --verbose since it doesn't do ↵Sam Kottler1-1/+1
anything
2014-04-04check_nt: add UPTIME to perfdata [sf#3434647]Jan Wagner1-1/+1
2014-04-03Fix check_mysql.c client options from fileawiddersheim1-6/+0
If you don't specify a group or a file to read data from the plugin tries to read from several files that don't exist and no groups.
2014-03-13check_pgsql: Add missing newline to --help outputHolger Weiss1-1/+1
2014-03-09build - avoid deprecated INCLUDESDavide Madrisan1-5/+6
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-02-20check_swap: Fix the plugin name that appears in the commentDavide Madrisan1-1/+1
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-02-18check_procs test fails if there is no user with uid 501Sven Nierlein1-9/+17
thats because check_procs verifys there is a user for a given uid filter. So even we use sample data for this test, we still need a real user. Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-02-17check_ssh: Reverting a387120Jan Wagner1-2/+0
This seems to result into more problems in the wild then before 'fixing' it Closes Debian #739254 Reopen Debian #734811