summaryrefslogtreecommitdiffstats
path: root/plugins
AgeCommit message (Collapse)AuthorFilesLines
2024-08-16check_curl: Documentation for --certificate, --cookie-jarAlvar Penning1-3/+6
From the mere help output for -C / --certificate, I was confused about what its two integer parameters do. Unfortunately, I also missed out on the explaining examples later. Since I like to have basic documentation for each flag, I tried to make the arguments as short as possible. The other fix was one hyphen too many for the --cookie-jar option.
2024-08-11check_curl: raise SSL issue when --continue-after-certificate is usedYannick Martin1-8/+9
This change aims to raise the worst status between the SSL check and the HTTP check. before: check_curl -H www.google.fr -S --continue-after-certificate --certificate 4000,4000 ; echo $? CRITICAL - Certificate '*.google.fr' expires in 74 day(s) (Tue 22 Oct 2024 12:53:52 PM GMT +0000). HTTP OK: HTTP/2 200 - 22807 bytes in 0.076 second response time |time=0.075516s;;;0.000000;10.000000 size=22807B;;;0; 0 after: /usr/lib/nagios/ovh/check_curl -H www.google.fr -S --continue-after-certificate --certificate 4000,4000 ; echo $? CRITICAL - Certificate '*.google.fr' expires in 74 day(s) (Tue 22 Oct 2024 12:53:52 PM GMT +0000). HTTP OK: HTTP/2 200 - 22840 bytes in 0.090 second response time |time=0.090463s;;;0.000000;10.000000 size=22840B;;;0; 2
2024-07-30check_curl: fix relative redirects on non-standard portSven Nierlein3-9/+32
Having a webserver respond with a relative redirect as for ex. in `Location: /path/to.html` check_curl would use the wrong standard http/https port instead of crafting the absolute url using the given scheme/hostname and port. Adding a new test case for this for check_http and check_curl. check_http did it correct already, so no fix necessary there. before: %>./check_curl -H 127.0.0.1 -p 50493 -f follow -u /redirect_rel -s redirected -vvv **** HEADER **** HTTP/1.1 302 Found ... Location: /redirect2 ... * Seen redirect location /redirect2 ** scheme: (null) ** host: (null) ** port: (null) ** path: /redirect2 Redirection to http://127.0.0.1:80/redirect2 fixed: %>./check_curl -H 127.0.0.1 -p 50493 -f follow -u /redirect_rel -s redirected -vvv **** HEADER **** HTTP/1.1 302 Found ... Location: /redirect2 ... * Seen redirect location /redirect2 ** scheme: (null) ** host: (null) ** port: (null) ** path: /redirect2 Redirection to http://127.0.0.1:50493/redirect2 Signed-off-by: Sven Nierlein <sven@nierlein.de>
2024-07-23Merge branch 'master' into check_curl_featuresSven Nierlein5-532/+588
2024-07-23check_http: replace www.mozilla.com with monitoring-plugins.orgSven Nierlein2-4/+4
this makes tests more reliable if we test our own sites instead some 3rd party site. Signed-off-by: Sven Nierlein <sven@consol.de>
2024-07-12check_ups: additional alarm conditions (#1961)Lorenz Kästle1-498/+545
* check_ups: * Update copyright * General refactoring * code formatting * Add ALARM state from ups -> Critical * Set some more states to be warnings
2024-04-12Adjust check_swap testsNapsty1-1/+1
2024-04-12Adjust check_swap testsNapsty1-1/+1
2024-04-12Adjust check_swap testsNapsty1-0/+12
2024-04-12Allow single thresholdNapsty1-8/+2
2024-04-12Possibility to run check_swap without thresholdsNapsty1-28/+31
2024-04-07check_http/check_curl: added a --regex-state option to change the state of a ↵Andreas Baumann2-6/+32
regex check from the default CRITICAL to something else (#1213)
2024-04-07check_curl/check_http: clarified format of POST data (#1978)Andreas Baumann2-2/+2
2024-04-07check_load: remove unused code (#1998)Lorenz Kästle1-26/+0
adaugherity noticed in issue #1965, that HAVE_PROC_LOADAVG is never defined since the symbol was removed from configure quite some time ago. This commit removes the dead code which would be used when the symbol would have been defined.
2024-03-27check_disk: Fail on missing arguments for --warning and --critical and fix a ↵Lorenz Kästle4-3/+45
test case (#1935) * check_disk: Fail on missing arguments for --warning and --critical * Add new test function for percentage expressions and use it in check_disk * Add error abort in tests if they fail to parse output * Fix typo in test which probably broke the test since forever :-(
2024-03-27check_ssh: patches from op5 (#1738)Lorenz Kästle2-76/+234
* check_ssh: properly parse a delayed version control string This resolves an issue with SSH servers which do not respond with their version control string as the first thing in the SSH protocol version exchange phase after connection establishment. This patch also makes sure that we disregard a potential comment in the version exchange string to avoid nonsense mismatches. In the future, we might want to add the capability to match against a user specified comment. In addition, the patch largely improves the communication towards the server, which adds better protocol adherence. Of course, new test cases are added to support the trigger and guard against regressions of the bugs solved by this patch. This fixes op5#7945 (https://bugs.op5.com/view.php?id=7945) Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh.t: Fix a few typos Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh: Handle non-alpha software versions This patch fixes a bug where we would reject version control strings that do not contain letters, because the assumption is made that they always do. This is not required by the RFC however, and there exist implementations that do not contain letters. I've also added a few references to the RFC to make the process of parsing the control string more apparent. This fixes op5#8716 (https://bugs.op5.com/view.php?id=8716) Signed-off-by: Anton Lofgren <alofgren@op5.com> * check_ssh: Fix a typo in "remote-protocol parameter remote-protcol -> remote-protocol Signed-off-by: Anton Lofgren <alofgren@op5.com> * Remove unused variable * Formating fixes * Update translations * Remove merge conflict artefact from previous merge * Set fixed include paths * Improve code style to be slightly more readable * Update test cases for different netcat behaviour and reduce sleep time --------- Signed-off-by: Anton Lofgren <alofgren@op5.com> Co-authored-by: Anton Lofgren <alofgren@op5.com>
2024-03-23check_swap: replace another fake boolen and small improvements (#1996)Lorenz Kästle1-10/+10
* check_swap: Change another fake boolen to a real one * check_swap: Rename type since *_t is reserved for C standard types * check_swap: Update copyright
2024-03-23check_nwstat: adds percentage used space (#1183)waja1-0/+53
* check_nwstat: adds percentage used space This adds the new VPU parameter to the check_nwstat plugin. This parameter returns the percentage used space on a Netware volume. Now you can monitor your Netware volumes easy. We use it with a warning 85% and critical 90%. eg: check_nwstat -H your.netware.host -v VPUvol1 -c 85 -w 90 returns 324653 MB (95%) used on volume vol1 - total 340212 MB|Used space in percent on vol1=95;90;80;0;100. * check_nwstat: Fixing whitespaces and tabs * Update translation files * check_nwstat: Use C99 booleans also with the patch * Some formatting --------- Co-authored-by: RincewindsHat <12514511+RincewindsHat@users.noreply.github.com>
2024-02-23check_disk increase alert precision (#1989)Sven Nierlein2-23/+7
* check_disk increase alert precision Free disk percentage value was rounded to a full integer meaning it alerted about ~1% percent too early. This is about 10GB on a 1TB disk. The warning and critical thresholds already support float values, so just the percentage calculation needs to be improved. old: ./check_disk -w 35% -c 20% -p / -f -vvv Thresholds(pct) for / warn: 35.000000 crit 20.000000 calling stat on / For /, used_pct=65 free_pct=35 used_units=286451 free_units=156651 total_units=443102 used_inodes_pct=11 free_inodes_pct=89 fsp.fsu_blocksize=4096 mult=1048576 Freespace_units result=0 Freespace% result=1 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 DISK WARNING - free space: WARNING [ / 156651MiB (35% inode=89%)];| /=300365643776B;302006979788;371700898201;0;464626122752 new: ./check_disk -w 35% -c 20% -p / -f -vvv Thresholds(pct) for / warn: 35.000000 crit 20.000000 calling stat on / For /, used_pct=64.649722 free_pct=35.350278 used_units=286464 free_units=156637 total_units=443102 used_inodes_pct=10.016183 free_inodes_pct=89.983817 fsp.fsu_blocksize=4096 mult=1048576 Freespace_units result=0 Freespace% result=0 Usedspace_units result=0 Usedspace_percent result=0 Usedinodes_percent result=0 Freeinodes_percent result=0 DISK OK - free space: / 156637MiB (35.4% inode=90%);| /=300379275264B;302006979788;371700898201;0;464626122752 * check_disk: adjust test case to support float precision
2024-02-12Merge pull request #1987 from euniceremoquillo/Improve-negate-plugin-helptextLorenz Kästle1-2/+4
Improve negate plugin helptext
2024-02-12Added indentions for readabilityEunice Remoquillo1-2/+2
2024-02-12Improve negate plugin helptextEunice Remoquillo1-2/+4
This commit updates the negate plugin's helptext as it is currently ambiguous.
2024-02-01check_curl: add haproxy protocol optionEmmanuel Riviere1-2/+15
2023-12-29check_snmp: Remove unused variableRincewindsHat1-4/+0
2023-12-29check_http: Remove self assignment of a variable and add some commentsRincewindsHat1-3/+2
2023-12-29Change iritating NULL assignmentRincewindsHat2-2/+2
2023-12-04check_procs: Generalise wording, remove mentioning of nrpeSven Hartge1-5/+4
2023-12-04check_procs: Improve help text, mentioning excluded processesSven Hartge1-14/+23
Also reindent the code, converting stray tabs to 2 spaces.
2023-11-28check_procs: ignore our own childrenSven Hartge1-0/+7
On systems with higher core counts check_procs will occasionally see its own "ps" child process with a high CPU percentage and raise a false alarm. Ignoring the child processes of check_procs prevents this from happening.
2023-11-27check_disk: fix ignore-missing in combination with includes (fixes #1963)Sven Nierlein2-18/+33
Using --ignore-missing together with regex matching and ignore option lead to a wrong error message. ./check_disk -n -w 10% -c 5% -W 10% -r /dummy -i /dummy2 DISK UNKNOWN: Paths need to be selected before using -i/-I. Use -A to select all paths explicitly The use case here is a cluster with fail-over mounts. So it is a valid situation that the regex match does not find anything in addtition with a ignore which also does not exist. After this patch: ./check_disk -n -w 10% -c 5% -W 10% -r /dummy -i /dummy2 DISK OK - No disks were found for provided parameters|
2023-11-27check_disk: add -n short option for --ignore-missingSven Nierlein1-6/+5
Signed-off-by: Sven Nierlein <sven@consol.de>
2023-11-23check_dns: Remove unused variableRincewindsHat1-1/+0
2023-11-23check_ntp_peer: Fixes for Wmaybe-unitialized and some restructuringRincewindsHat1-2/+11
2023-11-23Fix logic in is_uint64_t to fix type-limit warningRincewindsHat1-3/+12
2023-11-22Merge pull request #1951 from RincewindsHat/compiler_warnings_maybe_unusedLorenz Kästle3-3/+4
Fix compiler warning for uninitialized variable
2023-11-12Merge pull request #1958 from RincewindsHat/check_users_fix_segfaultLorenz Kästle2-9/+17
check_users: fix segfault
2023-11-10check_ups: output ups.realpower if supportedLouis Sautier1-7/+40
2023-10-31check_users: Update help to properly show that thresholds are rangesRincewindsHat1-4/+4
2023-10-31Enhance tests to check wheter the option validation worksRincewindsHat1-1/+4
2023-10-31check_users: Change option for sanity checking arguments to avoid segfaultRincewindsHat1-4/+9
2023-10-29Merge pull request #1953 from RincewindsHat/compiler_warnings-sign-compareLorenz Kästle12-65/+77
Fixes for -Wsign-compare
2023-10-19check_tcp: Fixes an error with using the wrong type for a variableRincewindsHat1-7/+8
2023-10-19Fix fallout of the previous changesRincewindsHat4-5/+5
2023-10-19Fixes for -Wsign-compareRincewindsHat11-55/+66
2023-10-19check_ntp: Initialize intermediate results in any caseRincewindsHat1-1/+2
2023-10-19check_curl: Initialize pointer before usageRincewindsHat1-1/+1
2023-10-19check_smtp: Restore behaviour pre ead5526efa4f713e8001baed409067b0474cb72d ↵RincewindsHat1-1/+10
regarding -D and TLS
2023-10-19check_dbi: Fix compiler warning for uninitialized variableRincewindsHat1-1/+1
2023-10-19check_ntp: Use C99 booleansRincewindsHat1-13/+14
2023-10-19Revert "check_ntp: Use C99 booleans"RincewindsHat1-13/+13
This reverts commit ca5af12f9475775179a599875bf7cf8d3296f02a.