From dd1e9eb5eadffa4a1519c7b67f65f5aa9c586145 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Thu, 28 Jun 2012 23:56:59 -0400 Subject: check_smtp: Change MAIL FROM: command to comply with the SMTP standard Every version of the SMTP standard (from RFC 821 to the current RFC 5321) requires the address following MAIL FROM: to follow the colon immediately (with no space) and to be surrounded by angle brackets. Signed-off-by: Anders Kaseorg --- plugins/check_smtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/check_smtp.c b/plugins/check_smtp.c index 0af50e32..56be585e 100644 --- a/plugins/check_smtp.c +++ b/plugins/check_smtp.c @@ -164,7 +164,7 @@ main (int argc, char **argv) printf("HELOCMD: %s", helocmd); /* initialize the MAIL command with optional FROM command */ - asprintf (&cmd_str, "%sFROM: %s%s", mail_command, from_arg, "\r\n"); + asprintf (&cmd_str, "%sFROM:<%s>%s", mail_command, from_arg, "\r\n"); if (verbose && smtp_use_dummycmd) printf ("FROM CMD: %s", cmd_str); -- cgit v1.2.3-74-g34f1