From df08974bf07bae1ea5dcbec68bad4cdfce52aeff Mon Sep 17 00:00:00 2001 From: Sven Nierlein Date: Thu, 31 Jul 2014 11:28:30 +0200 Subject: check_ntp_peer: do not use uninitialized results for max state s/t/jresult are not initialized if there is no corresponding threshold supplied. So we shouldn't use them for calculating our result. Signed-off-by: Sven Nierlein --- plugins/check_ntp_peer.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/plugins/check_ntp_peer.c b/plugins/check_ntp_peer.c index d3ae5999..44424af5 100644 --- a/plugins/check_ntp_peer.c +++ b/plugins/check_ntp_peer.c @@ -599,17 +599,20 @@ int main(int argc, char *argv[]){ } oresult = result; - if(do_truechimers) + if(do_truechimers) { tresult = get_status(num_truechimers, truechimer_thresholds); result = max_state_alt(result, tresult); + } - if(do_stratum) + if(do_stratum) { sresult = get_status(stratum, stratum_thresholds); result = max_state_alt(result, sresult); + } - if(do_jitter) + if(do_jitter) { jresult = get_status(jitter, jitter_thresholds); result = max_state_alt(result, jresult); + } switch (result) { case STATE_CRITICAL : -- cgit v1.2.3-74-g34f1