From fbb9050c648f23863bcac71bb608f31fec1ea352 Mon Sep 17 00:00:00 2001
From: RincewindsHat <12514511+RincewindsHat@users.noreply.github.com>
Date: Tue, 12 Sep 2023 15:48:44 +0200
Subject: Remove note about comments, we will accept // comments
---
doc/developer-guidelines.sgml | 3 ---
1 file changed, 3 deletions(-)
(limited to 'doc')
diff --git a/doc/developer-guidelines.sgml b/doc/developer-guidelines.sgml
index 1982974f..c900aeac 100644
--- a/doc/developer-guidelines.sgml
+++ b/doc/developer-guidelines.sgml
@@ -733,9 +733,6 @@ setup the tests. Run "make test" to run all the tests.
Variables should be declared at the beginning of code blocks and
not inline because of portability with older compilers.
- You should use /* */ for comments and not // as some compilers
- do not handle the latter form.
-
You should also avoid using the type "bool" and its values
"true" and "false". Instead use the "int" type and the plugins' own
"TRUE"/"FALSE" values to keep the code uniformly.
--
cgit v1.2.3-74-g34f1
From 565e23a7df9a99ac60c3dbc9692b33497423188b Mon Sep 17 00:00:00 2001
From: RincewindsHat <12514511+RincewindsHat@users.noreply.github.com>
Date: Tue, 12 Sep 2023 15:50:00 +0200
Subject: Switch guidelines to use bool instead of int for booleans
---
doc/developer-guidelines.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
(limited to 'doc')
diff --git a/doc/developer-guidelines.sgml b/doc/developer-guidelines.sgml
index c900aeac..37c963ed 100644
--- a/doc/developer-guidelines.sgml
+++ b/doc/developer-guidelines.sgml
@@ -733,9 +733,9 @@ setup the tests. Run "make test" to run all the tests.
Variables should be declared at the beginning of code blocks and
not inline because of portability with older compilers.
- You should also avoid using the type "bool" and its values
- "true" and "false". Instead use the "int" type and the plugins' own
- "TRUE"/"FALSE" values to keep the code uniformly.
+ You should use the type "bool" and its values
+ "true" and "false" instead of the "int" type for booleans.
+
Crediting sources
--
cgit v1.2.3-74-g34f1