From d332ee1fa09f09e6025d58a99876d96d50bbf439 Mon Sep 17 00:00:00 2001 From: phowen Date: Wed, 5 Apr 2017 10:27:37 +0100 Subject: resolve issues from code review diff --git a/.travis.yml b/.travis.yml index 78ebc30..0a559e7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -53,6 +53,7 @@ install: - sudo apt-get install -qq --no-install-recommends slapd ldap-utils - sudo apt-get install -qq --no-install-recommends autoconf automake - sudo apt-get install -qq --no-install-recommends faketime + - sudo apt-get install -qq --no-install-recommends libmonitoring-plugin-perl # Trusty related dependencies (not yet provided) - test "$(dpkg -l | grep -E "mysql-(client|server)-[0-9].[0-9]" | grep -c ^ii)" -gt 0 || sudo apt-get install -qq --no-install-recommends mariadb-client mariadb-server diff --git a/plugins-scripts/check_file_age.pl b/plugins-scripts/check_file_age.pl index dc49ce7..01b854a 100755 --- a/plugins-scripts/check_file_age.pl +++ b/plugins-scripts/check_file_age.pl @@ -57,7 +57,7 @@ GetOptions( "C=s" => \$opt_C, "critical-size=s" => \$opt_C); if ($opt_V) { - print_revision($PROGNAME, '2.2.22.g0d73b'); + print_revision($PROGNAME, '@NP_VERSION@'); exit $ERRORS{'UNKNOWN'}; } @@ -152,9 +152,9 @@ sub print_help () { print " If any of the warning and critical arguments are in range syntax (not just bare numbers)\n"; print " then all warning and critical arguments will be interpreted as ranges.\n"; print " To use range processing the perl module Monitoring::Plugin must be installed\n"; - print " For range syntax see https://nagios-plugins.org/doc/guidelines.html#THRESHOLDFORMAT\n"; + print " For range syntax see https://www.monitoring-plugins.org/doc/guidelines.html#THRESHOLDFORMAT\n"; print " It is strongly recommended when using range syntax that all four of -w, -W, -c and -C are specified\n"; - print " otherwise it is unlikely that the size test will be doint wat is desired\n"; + print " otherwise it is unlikely that the size test will be doing what is desired\n"; print "\n"; support(); } -- cgit v0.10-9-g596f