summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSven Nierlein <sven@nierlein.de>2021-04-12 17:21:47 +0200
committerSven Nierlein <sven@nierlein.de>2021-04-30 09:56:52 +0200
commit444a3579b2168eda949943a060bddff9ec95fd99 (patch)
tree1e20f3859f24e4459de02292c06f755663409b46
parentf0ac7fcc7c40fab04c00fbbc8c091e89e77b0f74 (diff)
downloadmonitoring-plugins-444a3579b2168eda949943a060bddff9ec95fd99.tar.gz
fix fping test
in case of dns errors, fping returns an unknown and thats ok.
-rw-r--r--plugins/t/check_fping.t9
1 files changed, 3 insertions, 6 deletions
diff --git a/plugins/t/check_fping.t b/plugins/t/check_fping.t
index 342b0a7e..03a6110e 100644
--- a/plugins/t/check_fping.t
+++ b/plugins/t/check_fping.t
@@ -12,9 +12,6 @@ use vars qw($tests);
12 12
13BEGIN {$tests = 4; plan tests => $tests} 13BEGIN {$tests = 4; plan tests => $tests}
14 14
15my $successOutput = '/^FPING OK - /';
16my $failureOutput = '/^FPING CRITICAL - /';
17
18my $host_responsive = getTestParameter("NP_HOST_RESPONSIVE", "The hostname of system responsive to network requests", "localhost"); 15my $host_responsive = getTestParameter("NP_HOST_RESPONSIVE", "The hostname of system responsive to network requests", "localhost");
19my $host_nonresponsive = getTestParameter("NP_HOST_NONRESPONSIVE", "The hostname of system not responsive to network requests", "10.0.0.1"); 16my $host_nonresponsive = getTestParameter("NP_HOST_NONRESPONSIVE", "The hostname of system not responsive to network requests", "10.0.0.1");
20my $hostname_invalid = getTestParameter("NP_HOSTNAME_INVALID", "An invalid (not known to DNS) hostname", "nosuchhost"); 17my $hostname_invalid = getTestParameter("NP_HOSTNAME_INVALID", "An invalid (not known to DNS) hostname", "nosuchhost");
@@ -29,9 +26,9 @@ if( ! -x "./check_fping") {
29elsif ( $> != 0 && (!$fping || ! -u $fping)) { 26elsif ( $> != 0 && (!$fping || ! -u $fping)) {
30 $t += skipMsg( "./check_fping", $tests ); 27 $t += skipMsg( "./check_fping", $tests );
31} else { 28} else {
32 $t += checkCmd( "./check_fping $host_responsive", 0, $successOutput ); 29 $t += checkCmd( "./check_fping $host_responsive", 0, '/^FPING OK - /' );
33 $t += checkCmd( "./check_fping $host_nonresponsive", [ 1, 2 ] ); 30 $t += checkCmd( "./check_fping $host_nonresponsive", 2, '/^FPING CRITICAL - /' );
34 $t += checkCmd( "./check_fping $hostname_invalid", [ 1, 2 ] ); 31 $t += checkCmd( "./check_fping $hostname_invalid", 3, '/^FPING UNKNOWN - /' );
35} 32}
36 33
37exit(0) if defined($Test::Harness::VERSION); 34exit(0) if defined($Test::Harness::VERSION);