diff options
author | phowen <phowen@cisco.com> | 2017-04-05 10:27:37 +0100 |
---|---|---|
committer | phowen <phowen@cisco.com> | 2017-04-05 10:27:37 +0100 |
commit | d332ee1fa09f09e6025d58a99876d96d50bbf439 (patch) | |
tree | 653755327bb30bda1397a272c98838a6d7ce4e10 | |
parent | 98a365d76c9b7e270d7b00953905d80c80c1467d (diff) | |
download | monitoring-plugins-d332ee1fa09f09e6025d58a99876d96d50bbf439.tar.gz |
resolve issues from code review
-rw-r--r-- | .travis.yml | 1 | ||||
-rwxr-xr-x | plugins-scripts/check_file_age.pl | 6 |
2 files changed, 4 insertions, 3 deletions
diff --git a/.travis.yml b/.travis.yml index 78ebc30b..0a559e7a 100644 --- a/.travis.yml +++ b/.travis.yml | |||
@@ -53,6 +53,7 @@ install: | |||
53 | - sudo apt-get install -qq --no-install-recommends slapd ldap-utils | 53 | - sudo apt-get install -qq --no-install-recommends slapd ldap-utils |
54 | - sudo apt-get install -qq --no-install-recommends autoconf automake | 54 | - sudo apt-get install -qq --no-install-recommends autoconf automake |
55 | - sudo apt-get install -qq --no-install-recommends faketime | 55 | - sudo apt-get install -qq --no-install-recommends faketime |
56 | - sudo apt-get install -qq --no-install-recommends libmonitoring-plugin-perl | ||
56 | # Trusty related dependencies (not yet provided) | 57 | # Trusty related dependencies (not yet provided) |
57 | - test "$(dpkg -l | grep -E "mysql-(client|server)-[0-9].[0-9]" | grep -c ^ii)" -gt 0 || sudo apt-get install -qq --no-install-recommends mariadb-client mariadb-server | 58 | - test "$(dpkg -l | grep -E "mysql-(client|server)-[0-9].[0-9]" | grep -c ^ii)" -gt 0 || sudo apt-get install -qq --no-install-recommends mariadb-client mariadb-server |
58 | 59 | ||
diff --git a/plugins-scripts/check_file_age.pl b/plugins-scripts/check_file_age.pl index dc49ce79..01b854a6 100755 --- a/plugins-scripts/check_file_age.pl +++ b/plugins-scripts/check_file_age.pl | |||
@@ -57,7 +57,7 @@ GetOptions( | |||
57 | "C=s" => \$opt_C, "critical-size=s" => \$opt_C); | 57 | "C=s" => \$opt_C, "critical-size=s" => \$opt_C); |
58 | 58 | ||
59 | if ($opt_V) { | 59 | if ($opt_V) { |
60 | print_revision($PROGNAME, '2.2.22.g0d73b'); | 60 | print_revision($PROGNAME, '@NP_VERSION@'); |
61 | exit $ERRORS{'UNKNOWN'}; | 61 | exit $ERRORS{'UNKNOWN'}; |
62 | } | 62 | } |
63 | 63 | ||
@@ -152,9 +152,9 @@ sub print_help () { | |||
152 | print " If any of the warning and critical arguments are in range syntax (not just bare numbers)\n"; | 152 | print " If any of the warning and critical arguments are in range syntax (not just bare numbers)\n"; |
153 | print " then all warning and critical arguments will be interpreted as ranges.\n"; | 153 | print " then all warning and critical arguments will be interpreted as ranges.\n"; |
154 | print " To use range processing the perl module Monitoring::Plugin must be installed\n"; | 154 | print " To use range processing the perl module Monitoring::Plugin must be installed\n"; |
155 | print " For range syntax see https://nagios-plugins.org/doc/guidelines.html#THRESHOLDFORMAT\n"; | 155 | print " For range syntax see https://www.monitoring-plugins.org/doc/guidelines.html#THRESHOLDFORMAT\n"; |
156 | print " It is strongly recommended when using range syntax that all four of -w, -W, -c and -C are specified\n"; | 156 | print " It is strongly recommended when using range syntax that all four of -w, -W, -c and -C are specified\n"; |
157 | print " otherwise it is unlikely that the size test will be doint wat is desired\n"; | 157 | print " otherwise it is unlikely that the size test will be doing what is desired\n"; |
158 | print "\n"; | 158 | print "\n"; |
159 | support(); | 159 | support(); |
160 | } | 160 | } |