diff options
author | RincewindsHat <12514511+RincewindsHat@users.noreply.github.com> | 2021-11-24 14:25:42 +0100 |
---|---|---|
committer | RincewindsHat <12514511+RincewindsHat@users.noreply.github.com> | 2021-11-24 14:25:42 +0100 |
commit | e2f24a5af3fe407035c8c57f539148f2d694973b (patch) | |
tree | 5c0037b638001cfad26a31af281fad50f6540147 | |
parent | 0e311b77d93df4b97c5f8cff73fea74a442ed4bc (diff) | |
download | monitoring-plugins-e2f24a5.tar.gz |
Fix CodeQL checks
-rw-r--r-- | plugins-root/check_icmp.c | 4 | ||||
-rw-r--r-- | plugins/check_disk.c | 16 | ||||
-rw-r--r-- | plugins/check_hpjd.c | 2 | ||||
-rw-r--r-- | plugins/check_swap.c | 2 |
4 files changed, 14 insertions, 10 deletions
diff --git a/plugins-root/check_icmp.c b/plugins-root/check_icmp.c index 519b93c6..bcf6c5f5 100644 --- a/plugins-root/check_icmp.c +++ b/plugins-root/check_icmp.c | |||
@@ -502,7 +502,7 @@ main(int argc, char **argv) | |||
502 | icmp_data_size = size; | 502 | icmp_data_size = size; |
503 | icmp_pkt_size = size + ICMP_MINLEN; | 503 | icmp_pkt_size = size + ICMP_MINLEN; |
504 | } else | 504 | } else |
505 | usage_va("ICMP data length must be between: %d and %d", | 505 | usage_va("ICMP data length must be between: %ul and %ul", |
506 | sizeof(struct icmp) + sizeof(struct icmp_ping_data), | 506 | sizeof(struct icmp) + sizeof(struct icmp_ping_data), |
507 | MAX_PING_DATA - 1); | 507 | MAX_PING_DATA - 1); |
508 | break; | 508 | break; |
@@ -1293,7 +1293,7 @@ add_target_ip(char *arg, struct sockaddr_storage *in) | |||
1293 | if(!host) { | 1293 | if(!host) { |
1294 | char straddr[INET6_ADDRSTRLEN]; | 1294 | char straddr[INET6_ADDRSTRLEN]; |
1295 | parse_address((struct sockaddr_storage*)&in, straddr, sizeof(straddr)); | 1295 | parse_address((struct sockaddr_storage*)&in, straddr, sizeof(straddr)); |
1296 | crash("add_target_ip(%s, %s): malloc(%d) failed", | 1296 | crash("add_target_ip(%s, %s): malloc(%ul) failed", |
1297 | arg, straddr, sizeof(struct rta_host)); | 1297 | arg, straddr, sizeof(struct rta_host)); |
1298 | } | 1298 | } |
1299 | memset(host, 0, sizeof(struct rta_host)); | 1299 | memset(host, 0, sizeof(struct rta_host)); |
diff --git a/plugins/check_disk.c b/plugins/check_disk.c index c526d056..f032378c 100644 --- a/plugins/check_disk.c +++ b/plugins/check_disk.c | |||
@@ -1040,9 +1040,15 @@ get_stats (struct parameter_list *p, struct fs_usage *fsp) { | |||
1040 | get_fs_usage (p_list->best_match->me_mountdir, p_list->best_match->me_devname, &tmpfsp); | 1040 | get_fs_usage (p_list->best_match->me_mountdir, p_list->best_match->me_devname, &tmpfsp); |
1041 | get_path_stats(p_list, &tmpfsp); | 1041 | get_path_stats(p_list, &tmpfsp); |
1042 | if (verbose >= 3) | 1042 | if (verbose >= 3) |
1043 | printf("Group %s: adding %llu blocks sized %llu, (%s) used_units=%g free_units=%g total_units=%g fsu_blocksize=%llu mult=%llu\n", | 1043 | printf("Group %s: adding %llu blocks sized %llu, (%s) used_units=%g free_units=%g total_units=%g mult=%llu\n", |
1044 | p_list->group, tmpfsp.fsu_bavail, tmpfsp.fsu_blocksize, p_list->best_match->me_mountdir, p_list->dused_units, p_list->dfree_units, | 1044 | p_list->group, |
1045 | p_list->dtotal_units, mult); | 1045 | tmpfsp.fsu_blocks, |
1046 | tmpfsp.fsu_blocksize, | ||
1047 | p_list->best_match->me_mountdir, | ||
1048 | p_list->dused_units, | ||
1049 | p_list->dfree_units, | ||
1050 | p_list->dtotal_units, | ||
1051 | mult); | ||
1046 | 1052 | ||
1047 | /* prevent counting the first FS of a group twice since its parameter_list entry | 1053 | /* prevent counting the first FS of a group twice since its parameter_list entry |
1048 | * is used to carry the information of all file systems of the entire group */ | 1054 | * is used to carry the information of all file systems of the entire group */ |
@@ -1065,12 +1071,10 @@ get_stats (struct parameter_list *p, struct fs_usage *fsp) { | |||
1065 | if (verbose >= 3) | 1071 | if (verbose >= 3) |
1066 | printf("Group %s now has: used_units=%g free_units=%g total_units=%g fsu_blocksize=%llu mult=%llu\n", | 1072 | printf("Group %s now has: used_units=%g free_units=%g total_units=%g fsu_blocksize=%llu mult=%llu\n", |
1067 | p->group, | 1073 | p->group, |
1068 | tmpfsp.fsu_bavail, | ||
1069 | tmpfsp.fsu_blocksize, | ||
1070 | p->best_match->me_mountdir, | ||
1071 | p->dused_units, | 1074 | p->dused_units, |
1072 | p->dfree_units, | 1075 | p->dfree_units, |
1073 | p->dtotal_units, | 1076 | p->dtotal_units, |
1077 | tmpfsp.fsu_blocksize, | ||
1074 | mult); | 1078 | mult); |
1075 | } | 1079 | } |
1076 | /* modify devname and mountdir for output */ | 1080 | /* modify devname and mountdir for output */ |
diff --git a/plugins/check_hpjd.c b/plugins/check_hpjd.c index 65465567..d3d72d7e 100644 --- a/plugins/check_hpjd.c +++ b/plugins/check_hpjd.c | |||
@@ -121,7 +121,7 @@ main (int argc, char **argv) | |||
121 | HPJD_GD_DOOR_OPEN, HPJD_GD_PAPER_OUTPUT, HPJD_GD_STATUS_DISPLAY); | 121 | HPJD_GD_DOOR_OPEN, HPJD_GD_PAPER_OUTPUT, HPJD_GD_STATUS_DISPLAY); |
122 | 122 | ||
123 | /* get the command to run */ | 123 | /* get the command to run */ |
124 | sprintf (command_line, "%s -OQa -m : -v 1 -c %s %s:%hd %s", PATH_TO_SNMPGET, community, | 124 | sprintf (command_line, "%s -OQa -m : -v 1 -c %s %s:%s %s", PATH_TO_SNMPGET, community, |
125 | address, port, query_string); | 125 | address, port, query_string); |
126 | 126 | ||
127 | /* run the command */ | 127 | /* run the command */ |
diff --git a/plugins/check_swap.c b/plugins/check_swap.c index 7f71bf7e..00bdcdd8 100644 --- a/plugins/check_swap.c +++ b/plugins/check_swap.c | |||
@@ -142,7 +142,7 @@ main (int argc, char **argv) | |||
142 | percent = 100 * (((double) dskused_mb) / ((double) dsktotal_mb)); | 142 | percent = 100 * (((double) dskused_mb) / ((double) dsktotal_mb)); |
143 | result = max_state (result, check_swap (dskfree_mb, dsktotal_mb)); | 143 | result = max_state (result, check_swap (dskfree_mb, dsktotal_mb)); |
144 | if (verbose) | 144 | if (verbose) |
145 | xasprintf (&status, "%s [%.0f (%d%%)]", status, dskfree_mb, 100 - percent); | 145 | xasprintf (&status, "%s [%ul (%d%%)]", status, dskfree_mb, 100 - percent); |
146 | } | 146 | } |
147 | } | 147 | } |
148 | /* | 148 | /* |