Merge branch 'master' into masterrefs/pull/1637/head

4 files changed, 14 insertions, 13 deletions

diff --git a/plugins-root/check_dhcp.c b/plugins-root/check_dhcp.c
index ad67323..2d22619 100644
--- a/plugins-root/check_dhcp.c
+++ b/plugins-root/check_dhcp.c
@@ -229,7 +229,7 @@ struct in_addr requested_address;
 
 int process_arguments(int, char **);
 int call_getopt(int, char **);
-int validate_arguments(int, int);
+int validate_arguments(int);
 void print_usage(void);
 void print_help(void);
 
@@ -470,10 +470,6 @@ int send_dhcp_discover(int sock){
         packet_xid=random();
         discover_packet.xid=htonl(packet_xid);
 
-        /**** WHAT THE HECK IS UP WITH THIS?!?  IF I DON'T MAKE THIS CALL, ONLY ONE SERVER RESPONSE IS PROCESSED!!!! ****/
-        /* downright bizzarre... */
-        ntohl(discover_packet.xid);
-
         /*discover_packet.secs=htons(65535);*/
         discover_packet.secs=0xFF;
 
@@ -1059,8 +1055,8 @@ int process_arguments(int argc, char **argv){
                 return ERROR;
 
         arg_index = call_getopt(argc,argv);
-        return validate_arguments(argc,arg_index);
-        }
+        return validate_arguments(argc);
+}
 
 
 
@@ -1158,13 +1154,13 @@ int call_getopt(int argc, char **argv){
         }
 
 
-int validate_arguments(int argc, int arg_index){
+int validate_arguments(int argc){
 
-        if(argc-optind > 0)
+        if(argc - optind > 0)
                 usage(_("Got unexpected non-option argument"));
 
         return OK;
-        }
+}
 
 
 #if defined(__sun__) || defined(__solaris__) || defined(__hpux__)
diff --git a/plugins-root/check_icmp.c b/plugins-root/check_icmp.c
index c3be2ef..1d47e9f 100644
--- a/plugins-root/check_icmp.c
+++ b/plugins-root/check_icmp.c
@@ -274,7 +274,7 @@ get_icmp_error_msg(unsigned char icmp_type, unsigned char icmp_code)
                 break;
 
         case ICMP_TIMXCEED:
-                /* really 'out of reach', or non-existant host behind a router serving
+                /* really 'out of reach', or non-existent host behind a router serving
                  * two different subnets */
                 switch(icmp_code) {
                 case ICMP_TIMXCEED_INTRANS: msg = "Time to live exceeded in transit"; break;
@@ -1432,15 +1432,20 @@ get_ip_address(const char *ifname)
 {
   // TODO: Rewrite this so the function return an error and we exit somewhere else
         struct sockaddr_in ip;
+        ip.sin_addr.s_addr = 0; // Fake initialization to make compiler happy
 #if defined(SIOCGIFADDR)
         struct ifreq ifr;
 
         strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name) - 1);
+
         ifr.ifr_name[sizeof(ifr.ifr_name) - 1] = '\0';
+
         if(ioctl(icmp_sock, SIOCGIFADDR, &ifr) == -1)
                 crash("Cannot determine IP address of interface %s", ifname);
+
         memcpy(&ip, &ifr.ifr_addr, sizeof(ip));
 #else
+        (void) ifname;
         errno = 0;
         crash("Cannot get interface IP address on this platform.");
 #endif
diff --git a/plugins-root/pst3.c b/plugins-root/pst3.c
index c3589f0..1f69f3a 100644
--- a/plugins-root/pst3.c
+++ b/plugins-root/pst3.c
@@ -257,6 +257,6 @@ void usage() {
   printf("\tRSS      - Real memory usage (kilobytes)\n");
   printf("\t%%CPU     - CPU usage\n");
   printf("\tCOMMAND  - Command being run\n");
-  printf("\tARGS     - Full command line with arguements\n");
+  printf("\tARGS     - Full command line with arguments\n");
   return;
 }
diff --git a/plugins-root/t/check_icmp.t b/plugins-root/t/check_icmp.t
index f6aa681..96addd3 100644
--- a/plugins-root/t/check_icmp.t
+++ b/plugins-root/t/check_icmp.t
@@ -92,5 +92,5 @@ like( $res->output, $successOutput, "Output OK" );
 $res = NPTest->testCmd(
         "$sudo ./check_icmp -H $host_responsive -b 65507"
         );
-is( $res->return_code, 0, "Try max paket size" );
+is( $res->return_code, 0, "Try max packet size" );
 like( $res->output, $successOutput, "Output OK - Didn't overflow" );