Merge pull request #1958 from RincewindsHat/check_users_fix_segfault

check_users: fix segfault

1 files changed, 13 insertions, 8 deletions

diff --git a/plugins/check_users.c b/plugins/check_users.c
index 7cf7a2cc..89b95369 100644
--- a/plugins/check_users.c
+++ b/plugins/check_users.c
@@ -227,18 +227,23 @@ process_arguments (int argc, char **argv)
         }
 
         c = optind;
+
         if (warning_range == NULL && argc > c)
                 warning_range = argv[c++];
+
         if (critical_range == NULL && argc > c)
                 critical_range = argv[c++];
 
         /* this will abort in case of invalid ranges */
         set_thresholds (&thlds, warning_range, critical_range);
 
-        if (thlds->warning->end < 0)
-                usage4 (_("Warning threshold must be a positive integer"));
-        if (thlds->critical->end < 0)
-                usage4 (_("Critical threshold must be a positive integer"));
+        if (!thlds->warning) {
+                usage4 (_("Warning threshold must be a valid range expression"));
+        }
+
+        if (!thlds->critical) {
+                usage4 (_("Critical threshold must be a valid range expression"));
+        }
 
         return OK;
 }
@@ -261,10 +266,10 @@ print_help (void)
         printf (UT_HELP_VRSN);
         printf (UT_EXTRA_OPTS);
 
-        printf (" %s\n", "-w, --warning=INTEGER");
-        printf ("    %s\n", _("Set WARNING status if more than INTEGER users are logged in"));
-        printf (" %s\n", "-c, --critical=INTEGER");
-        printf ("    %s\n", _("Set CRITICAL status if more than INTEGER users are logged in"));
+        printf (" %s\n", "-w, --warning=RANGE_EXPRESSION");
+        printf ("    %s\n", _("Set WARNING status if number of logged in users violates RANGE_EXPRESSION"));
+        printf (" %s\n", "-c, --critical=RANGE_EXPRESSION");
+        printf ("    %s\n", _("Set CRITICAL status if number of logged in users violates RANGE_EXPRESSION"));
 
         printf (UT_SUPPORT);
 }